-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create HIPS-style properties file #358
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Click here to view all benchmarks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hats #358 +/- ##
=======================================
Coverage ? 93.40%
=======================================
Files ? 49
Lines ? 1956
Branches ? 0
=======================================
Hits ? 1827
Misses ? 129
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond minor style concerns, I do have questions about the string split and decorator name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for such a thorough review, and teaching me things!
* Initial renaming (#352) * Initial renaming * A few more spots. * Docs issues found in code review. * Few more issues of bad find/replace... * Update unit test data with changes to hipscat-import (#354) * Update unit test data with changes to hipscat-import * Add new pylint config. * Create HIPS-style properties file (#358) * Update unit test data with changes to hipscat-import * Add new pylint config. * catalog_info.json -> properties. * Support hips-style space-delimited lists * Good type hint * Reduce duplication. * Changes from code review * Add default column to properties (#359) * Add default column to properties * Add fractional coverage on partition info * Add convenience import. * Clean it up * Comment about square degrees. * Add copy_and_update * replace hipscat index * update docs * fix typo * isort * rename test hipscat id * Improve reading/writing of fits file. (#361) * Improve reading/writing of fits file. * Pylint findings * Set total_rows to non-none value. (#362) * Code review comments. * change healpix to index type * update return type * Clean up straggling instances of hips/hipscat (#369) * Straggling instances of hips/hipscat * A little more cleanup * Insert dataset dir and use general ra/dec column names. (#377) * Insert dataset dir and use general ra/dec column names. * Update documentated directory structure. * Code review comments. --------- Co-authored-by: Sean McGuire <[email protected]> Co-authored-by: Sean McGuire <[email protected]>
Change Description
This introduces a java-style properties file, similar to the properties file in the HiPS standard.
This fully replaces the
catalog_info.json
file, and removes the provenance info handling from this library. Individual tools will optionally write out some tool arguments file (see #351).Closes #347, #348, #351
Related to issue #339, as the
hats_builder
kwarg will be used for importing tool name and date.Working branches that work with this change: